Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Perform fewer regexpCaptures when matching version numbers #16946

Merged
merged 1 commit into from
Jul 11, 2024
Merged

C#: Perform fewer regexpCaptures when matching version numbers #16946

merged 1 commit into from
Jul 11, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jul 10, 2024 •
edited
Loading

Needed in preparation for #16817.

@github-actions github-actions bot added the C# label Jul 10, 2024
@hvitved hvitved force-pushed the csharp/fewer-version-regexps branch from bcaab32 to 39b5dbf Compare July 10, 2024 12:51
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Jul 10, 2024
@hvitved hvitved marked this pull request as ready for review July 10, 2024 17:49
@hvitved hvitved requested a review from a team as a code owner July 10, 2024 17:49
tamasvajk
tamasvajk reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have sufficient amount of unit/integration tests covering this logic?

csharp/ql/lib/semmle/code/csharp/Location.qll Show resolved Hide resolved
@hvitved
Copy link
Contributor Author

hvitved commented Jul 11, 2024

Do we have sufficient amount of unit/integration tests covering this logic?

Yes, I think so; we have the test CompareVersions.ql (which called out bugs in my initial version).

@hvitved hvitved merged commit a452ead into github:main Jul 11, 2024
22 checks passed
@hvitved hvitved deleted the csharp/fewer-version-regexps branch July 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasvajk tamasvajk tamasvajk approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @tamasvajk